Skip to content

Preparing for 3.0.0 release #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Preparing for 3.0.0 release #157

merged 3 commits into from
Mar 6, 2019

Conversation

aliabbasrizvi
Copy link
Contributor

Summary

  • Updating version number and change log for 3.0.0 release.

@aliabbasrizvi aliabbasrizvi requested review from nchilada and a team March 6, 2019 09:02
@aliabbasrizvi
Copy link
Contributor Author

aliabbasrizvi commented Mar 6, 2019

To be merged after #154

@coveralls
Copy link

coveralls commented Mar 6, 2019

Coverage Status

Coverage remained the same at 98.078% when pulling 6ba81d6 on ali/prepare_for_3 into bdb4032 on master.

Copy link
Contributor

@nchilada nchilada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple typos, but otherwise good to merge!

CHANGELOG.md Outdated
* Experiments and features can no longer activate when a negatively targeted attribute has a missing, null, or malformed value.
* Audience conditions (except for the new `exists` matcher) no longer resolve to `false` when they fail to find an legitimate value for the targeted user attribute. The result remains `null` (unknown). Therefore, an audience that negates such a condition (using the `"not"` operator) can no longer resolve to `true` unless there is an unrelated branch in the condition tree that itself resolves to `true`.
* All methods now validate that user IDs are strings and that experiment keys, feature keys, feature variable keys, and event keys are non-empty strings.
* Ignore the user's whitelisted variation if it has been stopped. ([#123](Ignore the user’s whitelisted variation if it has been stopped. (#123))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I had a formatting typo on this line. Missing a closing bracket I think

@aliabbasrizvi aliabbasrizvi merged commit 7073e25 into master Mar 6, 2019
@aliabbasrizvi aliabbasrizvi deleted the ali/prepare_for_3 branch March 6, 2019 18:18
oakbani added a commit that referenced this pull request Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants